Skip to content

Fix documentation on using transient services #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix documentation on using transient services #870

wants to merge 2 commits into from

Conversation

Ryman
Copy link

@Ryman Ryman commented Aug 30, 2022

cc #51

Description

The documentation for setting up transient services was incorrect and references a scope property which isn't accepted by the Typescript compiler.

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

@Ryman
Copy link
Author

Ryman commented Jul 31, 2023

@attilaorosz (pinging you as you're the first human in the review history of master) Can you take a look at this?

@attilaorosz
Copy link
Member

The problem is that the latest dev branch has it and the documentation should be aligned with that. Unfortunately it is not released.

@NoNameProvided any plans on a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ryman @attilaorosz